feat(nginx): implement rate limiting for both dev and prod setup#36
Merged
feat(nginx): implement rate limiting for both dev and prod setup#36
Conversation
Collaborator
Author
Changes & RationaleAsymmetric Rate Limiting
Why: Bot & Connection Mitigation
Why: Cloudflare IP Resolution
Why: Static Path Isolation
Why: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Rate Limits added: Capped /banners and /banners/preview at 10 requests/min (burst=10 nodelay) to prevent spam from eating up our GitHub token quota.
429 Status: Configured Nginx to return 429 Too Many Requests instead of the default 503.
Prod Environment: Added Cloudflare's trusted IP ranges and set real_ip_header CF-Connecting-IP so Nginx rate-limits the actual user, not the CF proxy.
Dev Environment: Kept it simple with $binary_remote_addr for local testing.